Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix quick start example in the README #21

Merged
merged 1 commit into from
Jun 17, 2024
Merged

Fix quick start example in the README #21

merged 1 commit into from
Jun 17, 2024

Conversation

cottand
Copy link
Contributor

@cottand cottand commented Jun 17, 2024

The quick start example in the README was a copy pasta derived from the ./examples folder, and it had bugs (sorry). Closes #20

@cottand cottand requested a review from a team as a code owner June 17, 2024 08:57
@cottand cottand mentioned this pull request Jun 17, 2024
Closed
@cottand cottand requested a review from dinofizz June 17, 2024 10:59
@cottand cottand merged commit 7591f28 into master Jun 17, 2024
1 check passed
@cottand cottand deleted the nico.fix-readme-example branch June 17, 2024 11:00
@roshanr95
Copy link

Perfect, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dinofizz dinofizz dinofizz approved these changes

@nickrmc83 nickrmc83 nickrmc83 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hello world flake does not work for me
4 participants
@cottand @roshanr95 @nickrmc83 @dinofizz