-
Notifications
You must be signed in to change notification settings - Fork 51
Define environment requirements for Moodle 5.1 #361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the PostgreSQL database requirements for Moodle 5.1 by upgrading the minimum supported PostgreSQL version from 14 to 15, aligning with the environment requirements defined in MDL-85362.
- Updates PostgreSQL Docker image version in GitHub Actions configuration
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #361 +/- ##
=========================================
Coverage 88.33% 88.33%
Complexity 763 763
=========================================
Files 77 77
Lines 2348 2348
=========================================
Hits 2074 2074
Misses 274 274 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @HuongNV13,
Thanks for working on this, the change you've made looks correct, I'm just wondering whether we need to update any of these:
- Changelog (and potentially minor version bump?)
- .github/workflows/test.yml
- The Travis configs (.travis.yml or .travis.dist.yml) (not sure if these matter since they're going away).
|
Thanks, @mickhawkins .github/workflows/test.yml is designed to test selftest for this repo, but yes, I have modified it to Postgres 15 According to Travis CI, it has been deprecated in 4.5.8 and will be removed in 5.0.0. Cheers! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @HuongNV13, this looks good to me.
More details:
https://moodle.atlassian.net/browse/MDL-85362