Skip to content

Mobile 4842 #4581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 10, 2025
Merged

Mobile 4842 #4581

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e439d97
MOBILE-4842 rte: Remove invalid paramter passed to editor implementation
albertgasset Oct 8, 2025
f60a474
MOBILE-4842 theme: Remove footer bottom shadow
albertgasset Oct 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/core/features/editor/components/rich-text-editor/rich-text-editor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,6 @@ export class CoreEditorRichTextEditorComponent implements AfterViewInit, OnDestr
async ngOnInit(): Promise<void> {
this.editorComponentClass = await CoreEditorService.getEditorComponentClass();
this.editorComponentData = {
name: this.name,
placeholder: this.placeholder,
component: this.component,
componentId: this.componentId,
Expand Down
2 changes: 1 addition & 1 deletion src/core/features/mainmenu/pages/more/more.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ <h1>{{ 'core.more' | translate }}</h1>
}
</ion-list>
</ion-content>
<ion-footer class="ion-no-border">
<ion-footer>
<ion-item button (click)="openSettings()" [attr.aria-label]="'core.settings.appsettings' | translate" [detail]="true">
<ion-icon name="fas-gears" slot="start" aria-hidden="true" />
<ion-label>
Expand Down
5 changes: 5 additions & 0 deletions src/theme/theme.base.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,11 @@ ion-app > ion-modal.core-modal-lateral {
--ion-safe-area-top: inherit;
}

// Remove footer bottom shadow (Android only).
ion-footer.md {
clip-path: inset(-12px 0px 0px 0px);
}

ion-tabs.placement-side .tabs-inner {
--ion-safe-area-left: 0px;
}
Expand Down