fix: Remove style attribute from body for prevent unexpected backgrou… #1
Conversation
| @@ -38,9 +38,6 @@ function clearBackground() { | |||
| if (body.style) { | |||
| body.style.backgroundColor = 'rgba(0,0,0,0.01)'; | |||
| body.style.backgroundImage = ''; | |||
| setTimeout(function() { | |||
There was a problem hiding this comment.
Why is it necessary to remove this?
There was a problem hiding this comment.
Is not required remove that, I found other solution.
| @@ -159,6 +156,9 @@ return { | |||
| }, | |||
| destroy: function(callback) { | |||
| cordova.exec(doneCallback(callback, true), null, 'QRScanner', 'destroy', []); | |||
| setTimeout(function() { | |||
| document.body.removeAttribute('style'); | |||
There was a problem hiding this comment.
Instead of removing all the styles, would it be feasible to just clear the ones updated by this plugin? Maybe we should even store the initial values if they were set on the body. I don't think any of this is too likely to happen, but it's a more robust implementation and when working with plugins you never know how they'll interact with other plugins.
package.json
Outdated
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "@moodlehq/cordova-plugin-qrscanner", | |||
| "version": "3.0.1-moodle.2", | |||
| "version": "3.0.1-moodle.3", | |||
There was a problem hiding this comment.
Instead of bumping the version number here, we should do it on a separate release commit. Other than that, I think this is a good candidate to contribute to the original plugin at https://github.com/bitpay/cordova-plugin-qrscanner, so you could open a PR there and then add it to this repo so that we don't have to wait for them to merge it. This is the same we did with bitpay#266 as documented in the README.
alfonso-salces
force-pushed
the
dev
branch
2 times, most recently
from
0ba938a to
5c2825a
Compare
…nds.