Fix: Add configurable transaction mortality period #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses issue where offline-signed transactions expire too quickly. Changes: - Add --era-period CLI parameter to create and createAndSend commands - Maintain safe default of 2048 blocks (~6.8 hours on Moonbeam) - Add robust validation: must be power of 2 and >= 4 - Add warnings for periods > 4096 blocks about potential risks - Improve error handling for JSON parsing and command execution - Update documentation with clear guidance on mortality options - Enhanced error messages for expired transactions with nonce hints For offline batch signing scenarios, users can now: 1. Use --immortality for transactions that never expire 2. Use --era-period with larger values (e.g., 8192, 16384) 3. Continue using default for standard online scenarios Security considerations documented in README to help users understand trade-offs between longer validity periods and replay/upgrade risks. Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue where offline-signed transactions expire too quickly by adding configurable era-period parameter. Default remains 2048 blocks for backward compatibility.