CI 📈: Add workflow for checking changes to weights in all runtimes#3129
Merged
CI 📈: Add workflow for checking changes to weights in all runtimes#3129
Conversation
pLabarta
added
B0-silent
Contributor
WASM runtime size check:Compared to target branchMoonbase runtime: 2420 KB (no changes) 🚨 Moonbeam runtime: 2404 KB (no changes) 🚨 Moonriver runtime: 2392 KB (no changes) ✅ Compared to latest release (runtime-3401)Moonbase runtime: 2420 KB (+388 KB compared to latest release) 🚨 Moonbeam runtime: 2404 KB (+392 KB compared to latest release) 🚨 Moonriver runtime: 2392 KB (+380 KB compared to latest release) |
Contributor
Coverage Report@@ Coverage Diff @@
## master pablo/ext-weight-diff-report +/- ##
===============================================================
Coverage 74.59% 74.59% 0.00%
Files 380 380
Lines 96029 96029
===============================================================
Hits 71632 71632
Misses 24397 24397
|
RomarQ
reviewed
Jan 17, 2025
Co-authored-by: Rodrigo Quelhas <22591718+RomarQ@users.noreply.github.com>
RomarQ
approved these changes
Feb 4, 2025
TarekkMA
approved these changes
Feb 4, 2025
stiiifff
approved these changes
Feb 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does it do?
This PR adds a new CI workflow which checks if files inside the
weightsfolder changed for each runtime and generates a report of the changes sorted by Change %. It will only run for PRs that change the files generated by benchmarks.Reports look like the following:
What important points reviewers should know?
Is there something left for follow-up PRs?
Currently, big changes might generate massive reports. If they end up being unreadable, this workflow could be changed to show only a summary in the PR discussion and upload full reports as artifacts or publish them as HTML pages.
What alternative implementations were considered?
Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
What value does it bring to the blockchain users?