-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update deprecated option in benchmarks script #3138
Draft
manuelmauro
wants to merge
12
commits into
master
Choose a base branch
from
manuel/update-deprecation-in-benchmarks-script
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Update deprecated option in benchmarks script #3138
manuelmauro
wants to merge
12
commits into
master
from
manuel/update-deprecation-in-benchmarks-script
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WASM runtime size check:Compared to target branchMoonbase runtime: 2408 KB (no changes) 🚨 Moonbeam runtime: 2396 KB (no changes) ✅ Moonriver runtime: 2404 KB (no changes) 🚨 Compared to latest release (runtime-3401)Moonbase runtime: 2408 KB (+376 KB compared to latest release) 🚨 Moonbeam runtime: 2396 KB (+384 KB compared to latest release) Moonriver runtime: 2404 KB (+392 KB compared to latest release) 🚨 |
Coverage Report@@ Coverage Diff @@
## master manuel/update-deprecation-in-benchmarks-script +/- ##
==================================================================================
- Coverage 74.58% 74.14% -0.44%
+ Files 377 380 +3
+ Lines 96042 96672 +630
==================================================================================
+ Hits 71632 71675 +43
+ Misses 24410 24997 +587
|
…mand within the script
manuelmauro
changed the title
Update deprecation in benchmarks script
Update deprecated option in benchmarks script
Jan 20, 2025
This reverts commit 52436cb.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
When running
run-benches-for-runtime.sh
to generate the runtime weights, the following warning appears in the logs:This PR updates the script to use
--runtime <runtime>
instead of--chain=<chain-spec>
.What important points reviewers should know?
Is there something left for follow-up PRs?
What alternative implementations were considered?
Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
What value does it bring to the blockchain users?