Skip to content

docs: prefer 'moonbit check' over 'moonbit nocheck' in README - #5

Merged
bobzhang merged 1 commit into
mainfrom
chore/prefer-moonbit-check
Apr 18, 2026
Merged

bobzhang merged 1 commit into
mainfrom
chore/prefer-moonbit-check

Conversation

@bobzhang

@bobzhang bobzhang commented Apr 18, 2026 •

Copy link
Copy Markdown
Contributor

Enables the embedded doctests to actually be type-checked by moon check.

moon fmt respects the explicit moonbit check marker. moon check --deny-warn and moon test are both green.

🤖 Generated with Claude Code


Open in Devin Review

moon fmt respects the explicit 'moonbit check' marker, so the embedded
doctests can actually be type-checked. moon check --deny-warn and
moon test are both green.

Generated with Claude Code (https://claude.com/claude-code).

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

View 2 additional findings in Devin Review.

Open in Devin Review

Comment thread README.mbt.md

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 Incorrect assertion in file_search_example: expects false but result is true

The file_search_example test searches for "main" across 4 files and filters those with score > 0. Only "src/main.mbt" and "test/main_test.mbt" contain the subsequence m-a-i-n; "docs/README.md" has no a after m, and "package.json" has no m at all. So exactly 2 results are returned, making results.length() == 2 evaluate to true. However, inspect(results.length() == 2, content="false") asserts the value should be "false". This was harmless when the block was moonbit nocheck, but the PR switches it to moonbit check, meaning this incorrect assertion will now be validated and cause a test failure when these doc tests are run (moon test).

(Refers to line 170)

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

@bobzhang
bobzhang merged commit a465439 into main Apr 18, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant