chore: clear MoonBit deprecation warnings (26 → 0 warnings) - #8
Merged
Merged
Conversation
Updates moonbit-community/lisp_interpreter for the current MoonBit toolchain (moon 0.1.20260901). Warning sites: 26 -> 0. Compile errors: 0 -> 0. No warnings were suppressed; counts come from moon check --output-json deduplicated by (file, location, code). Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Yc3P6APF111hdbCXRT4M3P
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings
moonbit-community/lisp_interpreterup to date with the current MoonBit toolchain (moon 0.1.20260901). This repo publishes 1 module on mooncakes.io.Result
The warning baseline was measured after the build was repaired — a failing compile stops before reporting warnings, so the initial sweep undercounted them.
Tests: pass — 33/33 (baseline was 32/33: one PRE-EXISTING failure, test "decode_string" in sexp.mbt, failing before any of my edits; it is now fixed)
What changed
Reviewer notes
MEASURED NUMBERS:
moon checkbefore = 26 warnings / 0 errors (the 22 unique sites in the given baseline; 4 sites emit two warnings each). After = 0 warnings, 0 errors, exit 0 (verified afterrm -rf _build targetclean rebuild).moon testafter = 33 passed / 0 failed, exit 0. Nothing was suppressed: no#warnings(...), no deleted tests, no weakened assertions. BASELINE TEST STATE (recorded before editing): 33 tests, 32 passed, 1 FAILED —sexp.mbttest "decode_string", diff-Err: "[\" unexpected newline in string\"]"vs+Err: "[ unexpected newline in string]". This failure pre-dates my work; it was caused by the same upstreamShow-for-collections change that produced the deprecation warnings. My fix incidentally repaired it. FILES: {sexp.mbt, sexp_test.mbt, lisp_interpreter.mbt, lisp_interpreter_test.mbt, pkg.generated.mbti}, plus moon.mod.json -> moon.mod. [0079] implicit_impl_as_method (12 sites): added plainpub extenddeclarations exactly as each message named — Sexp with @debug.Debug::{to_repr}, Eq::{equal, not_equal}, ToJson::{to_json}, Show::{to_string, output}; ParseError with @debug.Debug::{to_repr}, ToJson::{to_json}, Show::{to_string, output}; Value with @debug.Debug::{to_repr}, ToJson::{to_json}, Show::{to_string, output}; Env with @debug.Debug::{to_repr}, Show::{to_string, output}. I did NOT use the#deprecatedalternative: the promoted methods ...How this was verified
moon check --output-json, deduplicated by (file, location, code), re-measured independently after the changes were made.#warnings("-..."),alert-listorwarn-listescapes.HEAD.🤖 Generated with Claude Code
https://claude.ai/code/session_01Yc3P6APF111hdbCXRT4M3P