chore: clear MoonBit deprecation warnings (5 → 0 warnings) - #9
Merged
Merged
Conversation
Updates moonbit-community/qrc for the current MoonBit toolchain (moon 0.1.20260901). Warning sites: 5 -> 0. Compile errors: 0 -> 0. No warnings were suppressed; counts come from moon check --output-json deduplicated by (file, location, code). Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Yc3P6APF111hdbCXRT4M3P
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings
moonbit-community/qrcup to date with the current MoonBit toolchain (moon 0.1.20260901). This repo publishes 1 module on mooncakes.io.Result
Tests: 23/23 passed (baseline before edits: 23/23 passed, 0 failed) — no regressions, no snapshot updates needed
What changed
pub extend T with Eq::{not_equal, equal}declarations for ErrorCorrectionLevel (qrc.mbt:9), Mode (qrc.mbt:19), Module (qrc.mbt:32) and MaskPattern (qrc.mbt:1027), making the previously-implicit promotion of derived Eq methods explicitArray::new(capacity=size)->Array(capacity=size)innew_matrix(only Array::new site in the repo)moon fmt(the deprecated JSON module-metadata format was removed by the tool); content carried over faithfullyoptions("is-main": true)->pkgtype(kind: "executable"), rewritten automatically bymoon fmtKnowingly left alone
moon check --warn-list +unnecessary_annotation; it is off by default, was not in the 5-warning baseline, and defaultmoon checkis now at 0 warnings. These are over-qualified enum constructor...Reviewer notes
All numbers are measured from real command runs, not estimates. VERIFICATION - Final
moon check --output-json: 0 warnings, 0 errors (exit 0). Also clean on all four backends checked individually: wasm-gc, wasm, js, native. -moon test: 23/23 passed both before and after. Baseline was recorded before any edit, so no pre-existing failure was misattributed. -moon buildsucceeds andmoon run mainstill renders a correct QR code (Version 2, 25x25, Byte mode, EC level M) — this also sanity-checks thepkgtype(kind: "executable")rewrite in main/moon.pkg. - No#warnings("-...")suppressions, no deleted tests, no weakened assertions, no#deprecatedescape hatches. Nothing under .mooncakes/ was touched. PUBLIC API / mbti CHANGES (pkg.generated.mbti) - pkg.generated.mbti gains 8 explicit lines —equal/not_equalfor each of ErrorCorrectionLevel, MaskPattern, Mode, Module. This is a declaration of what was already there, not a new capability: these methods were previously being promoted implicitly by the compiler (which is exactly what warning 0079 was reporting), so every call site that compiled before still compiles. Theextendform was chosen over per-type manual methods, and over#deprecated-ing the promotion, becausebobzhang/qrcis a published mooncakes.io module and external consumers may callx.equal(y)in dot form. I confirmed there are zero.equal(...How this was verified
moon check --output-json, deduplicated by (file, location, code), re-measured independently after the changes were made.#warnings("-..."),alert-listorwarn-listescapes.HEAD.🤖 Generated with Claude Code
https://claude.ai/code/session_01Yc3P6APF111hdbCXRT4M3P