Allow "swap A/B and X/Y gamepad buttons" to be configured separately for in-stream and in-UI #1145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Currently, there is an option to swap A/B and X/Y buttons for gamepads, to emulate nintendo-style button layouts. This option applies to both navigation in Moonlight UI, and to button inputs sent to the host PC. This PR separates the setting into two: one for navigation in UI, and one for inputs sent to host PC.
To keep compatibility with old configs, the default for these two options will be "true" if the previous setting's value was "true" in the user's settings file. Similarly, if the old command line arg is passed, it enables both new options. If the new command line args or settings are provided, they override the old value.
Related items
Closes #1137.