Add processing to resolve input issues on Japanese keyboard layout. #1589
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgutman
reviewed
Jul 4, 2025
| KEY_ACTION_DOWN, | ||
| modifiers, | ||
| shouldNotConvertToScanCodeOnServer ? SS_KBE_FLAG_NON_NORMALIZED : 0); | ||
| m_KeysDown.insert(keyCode); |
There was a problem hiding this comment.
This seems like it might be a broader SDL bug. Can you try one of the SDL test apps (ex: testgles2) with SDL_EVENT_LOGGING=1 environment variable set and see if you get reversed up/down events there too?
There was a problem hiding this comment.
I believe the issue lies in the fact that, on Japanese keyboards, when the Hankaku/Zenkaku (half-width/full-width) key is pressed, the OS issues a virtual key code that behaves differently from standard keys — it sends a "true" (released) event and immediately follows it with a "false" (pressed) event. (Scan code 41)
Here are the keyboard inputs obtained using a keylogger.
| Datetime | Virtual Key Code | Scan Code | Extended Key Flag | Injected Flag | Context Code | Transition State Flag | Timestamp | Extra Info | Virtual Key Name | Display Name |
|---|---|---|---|---|---|---|---|---|---|---|
| 07/06 12:02:44.407 | 65 | 30 | False | False | False | False | 298892765 | 0 | VK_A | A key |
| 07/06 12:02:44.551 | 65 | 30 | False | False | False | True | 298892921 | 0 | VK_A | A key |
| 07/06 12:02:44.947 | 66 | 48 | False | False | False | False | 298893312 | 0 | VK_B | B key |
| 07/06 12:02:45.038 | 66 | 48 | False | False | False | True | 298893406 | 0 | VK_B | B key |
| 07/06 12:02:46.342 | 67 | 46 | False | False | False | False | 298894703 | 0 | VK_C | C key |
| 07/06 12:02:46.431 | 67 | 46 | False | False | False | True | 298894796 | 0 | VK_C | C key |
| 07/06 12:02:47.435 | 244 | 41 | False | False | False | True | 298895796 | 0 | VK_OEM_ENLW | OEM specific |
| 07/06 12:02:47.437 | 243 | 41 | False | False | False | False | 298895796 | 0 | VK_OEM_AUTO | OEM specific |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Fixed unrecognized
\/_keyIn Japanese keyboard environments, Moonlight was unable to detect input from the key immediately to the left of the right Shift (the
\/_key). This update ensures that those scancodes are now correctly recognized and processed.Corrected inverted Hankaku/Zenkaku key events
On Japanese keyboards, the key immediately to the left of
1(the Hankaku/Zenkaku key) was generating its PRESSED and RELEASE events in reverse. We’ve added logic to invert those two event states so that PRESSED and RELEASE are reported correctly.Test Environment