Minor refactoring of cuid internals #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m class. Fixed potential bug in DateTime usage - uses UtcNow instead of Now.
NCuid project supports .NET Standard 2.0 and .NET 4.6
…e the seed integer during construction of per-thread Random objects for better pseudo-randomness.
Reinstated version generation using MSBuild custom task
fabiob
approved these changes
Jul 12, 2019
|
@moonpyk, are you still active here? I'm really interested in this PR. |
|
@fabiob Yup I'm still active, just back from holidays, I'll try to have a look on your PR ASAP, sorry for the wait |
moonpyk
requested changes
Aug 31, 2020
| @@ -8,14 +8,15 @@ | |||
| <AppDesignerFolder>Properties</AppDesignerFolder> | |||
| <RootNamespace>NCuid.Tests</RootNamespace> | |||
| <AssemblyName>NCuid.Tests</AssemblyName> | |||
| <TargetFrameworkVersion>v4.5</TargetFrameworkVersion> | |||
| <TargetFrameworkVersion>v4.6</TargetFrameworkVersion> | |||
There was a problem hiding this comment.
Was the target framework change an obligation ?
| @@ -1,7 +1,7 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
| <Project xmlns="http://schemas.microsoft.com/developer/msbuild/2003" ToolsVersion="4.0"> | |||
| <PropertyGroup> | |||
| <AssemblyVersion>1.0.0.*</AssemblyVersion> | |||
| <AssemblyVersion>1.0.0.0</AssemblyVersion> | |||
There was a problem hiding this comment.
Could you please leave the star at the end?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored random block generation logic to avoid recreation of Random class. (deals with issue in tracker)
Use of Random class is now thread-safe (using thread-local wrapper).
Random class is initialised using a cryptographically secure random seed.
Fixed potential bug in DateTime usage - uses UtcNow instead of Now.
Project file updated to generate .NET Standard 2.0 and .NET 4.6 assemblies.