Merge pull request #43 from acoshift/nil-result

handle nil result

handler.go

@@ -8,7 +8,11 @@ import (
 func Wrap(h Handler) http.Handler {
 	return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
 		ctx := NewContext(w, r)
-		h(ctx).ServeHTTP(ctx.w, ctx.r)
+
+		result := h(ctx)
+		if result != nil {
+			result.ServeHTTP(ctx.w, ctx.r)
+		}
 	})
 }
 

result.go

@@ -104,9 +104,7 @@ func (ctx *Context) Error(error string) Result {
 
 // Nothing does nothing
 func (ctx *Context) Nothing() Result {
-	return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
-		// do nothing
-	})
+	return nil
 }
 
 // NotFound calls http.NotFound

result_test.go

@@ -124,6 +124,21 @@ func TestResult(t *testing.T) {
 		assert.Equal(t, "hello, hime", w.Body.String())
 	})
 
+	t.Run("Nil", func(t *testing.T) {
+		t.Parallel()
+
+		app := hime.New().
+			Handler(hime.H(func(ctx *hime.Context) hime.Result {
+				return nil
+			}))
+
+		assert.NotPanics(t, func() {
+			w := invokeHandler(app, "GET", "/", nil)
+			assert.Equal(t, http.StatusOK, w.Result().StatusCode)
+			assert.Empty(t, w.Body.String())
+		})
+	})
+
 	t.Run("Nothing", func(t *testing.T) {
 		t.Parallel()