Skip to content

Fix Korean model metadata mismatch#126

Open
dipeshbabu wants to merge 1 commit intomoonshine-ai:mainfrom
dipeshbabu:fix/ko-model-name-tiny
Open

Fix Korean model metadata mismatch#126
dipeshbabu wants to merge 1 commit intomoonshine-ai:mainfrom
dipeshbabu:fix/ko-model-name-tiny

Conversation

@dipeshbabu
Copy link

This PR fixes an inconsistency in the Korean model entry in python/src/moonshine_voice/download.py. The ko entry used model_name="base-ko" while the architecture and URL clearly point to tiny-ko. This updates model_name to tiny-ko to match.

@deepj3671-png
Copy link

  1. Thanks for catching this metadata mismatch! It makes sense to align the model_name with the tiny - ko architecture. LGTM.
  2. Good catch! Could you explain how this inconsistency was originally found? It helps to understand the verification process.
  3. Verified the fix regarding the Korean model metadata. It correctly points o tiny-ko. Thanks for the update!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants