Fix Korean model metadata mismatch#126
Closed
dipeshbabu wants to merge 1 commit intomoonshine-ai:mainfrom
Closed
Conversation
This comment was marked as spam.
This comment was marked as spam.
Contributor
|
We're actually hitting some accuracy issues where base Korean seems to have similar or higher WER than tiny, and this is our current workaround. We'll keep investigating what's going wrong, but closing this for now. Thanks for the report @dipeshbabu |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an inconsistency in the Korean model entry in
python/src/moonshine_voice/download.py. Thekoentry usedmodel_name="base-ko"while the architecture and URL clearly point totiny-ko. This updatesmodel_nametotiny-koto match.