Skip to content

Docs: fix embedding model_name examples in get_embedding_model#127

Open
dipeshbabu wants to merge 1 commit intomoonshine-ai:mainfrom
dipeshbabu:docs/embedding-model-name-example
Open

Docs: fix embedding model_name examples in get_embedding_model#127
dipeshbabu wants to merge 1 commit intomoonshine-ai:mainfrom
dipeshbabu:docs/embedding-model-name-example

Conversation

@dipeshbabu
Copy link

This PR updates the get_embedding_model docstring examples to use the actual supported key embeddinggemma-300m. Previously, the docs referenced gemma-300m, which would raise a ValueError if copied directly.

@deepj3671-png
Copy link

  1. Looks good to me, thanks for fixing thus documentation error".
  2. Verified the change, it correctly points to the supported model name. LGTM (Looks Good To Me).
  3. Could you explain why the model name was changed from 'gemma-300m' to 'embeddinggemma-300m'? Is this a requirement for the latest version?"
  4. Thanks for the fix! Have you tested if this change works correctly in the runtime environment?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants