fix: change path to sprite; issues: vitejs/vite#4454 ; add icon to fa…

…vicon;
moonzaki · Nov 10, 2024 · 23cf006 · 23cf006
1 parent e727b04
commit 23cf006
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 5 deletions.
diff --git a/public/vite.svg b/public/vite.svg
diff --git a/src/components/NoteAddButton/NoteAddButton.jsx b/src/components/NoteAddButton/NoteAddButton.jsx
@@ -1,11 +1,14 @@
 import NoteButton from '../NoteButton/NoteButton';
 import './NoteAddButton.scss';
 
-function NoteAddButton({clearForm}) {
+function NoteAddButton({ clearForm }) {
+
+  const baseUrl = import.meta.env.BASE_URL;
+
   return (
     <NoteButton className="note-add" onClick={clearForm}>
       <svg width="20" height="21" viewBox="0 0 20 21">
-        <use href="/sprite.svg#add-svg"></use>
+        <use href={`${baseUrl? baseUrl + '/': ''}sprite.svg#add-svg`}></use>
       </svg>
       New memory
     </NoteButton>

diff --git a/src/components/NoteForm/NoteForm.jsx b/src/components/NoteForm/NoteForm.jsx
@@ -86,7 +86,7 @@ function NoteForm({ callback, data, setCurrentItem, delItem }) {
     }
   };
 
-
+  const baseUrl = import.meta.env.BASE_URL;
 
   return (
     <form className={styles['note-form']} onSubmit={addNoteItem}>
@@ -124,7 +124,7 @@ function NoteForm({ callback, data, setCurrentItem, delItem }) {
       </div>
       <div className={styles['input-wrapper']}>
         <svg width="18" height="18" viewBox="0 0 18 18">
-          <use href="/sprite.svg#tag-svg"></use>
+          <use href={`/${baseUrl? baseUrl + '/' : ''}sprite.svg#tag-svg`}></use>
         </svg>
         <p>Tags</p>
         <input

diff --git a/vite.config.js b/vite.config.js
@@ -3,6 +3,6 @@ import react from '@vitejs/plugin-react-swc';
 
 // https://vite.dev/config/
 export default defineConfig({
-  base: process.env.NODE_ENV === 'production' ? '/your-repo-name/' : '/',
+  base: process.env.NODE_ENV === 'production' ? '/notes-app/' : '/',
   plugins: [react()]
 });