fix(ui): escape dynamic HTML in dashboard and memory views#1506
Open
pawanrahul370-commits wants to merge 2 commits into
Open
fix(ui): escape dynamic HTML in dashboard and memory views#1506pawanrahul370-commits wants to merge 2 commits into
pawanrahul370-commits wants to merge 2 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe UI now escapes dynamic dashboard, playground, explorer, memory-table, and error content before HTML insertion. Static regression tests verify escaped expressions and the revised memory action wiring. ChangesUI HTML Escaping Hardening
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #770
Summary
innerHTML.data-memory-idattribute to avoid inline JavaScript string interpolation.Reproduction
innerHTML. After this patch, they render as text viaescHtml(...)or safe data attributes.Tests
python -m pytest tests/test_ui_static_xss.pypython -m pytest tests/test_ui_auth.py tests/test_remaining_ui_auth.pySummary by CodeRabbit
Bug Fixes
Tests