Skip to content

fix: fix(mcp): restrict automatic agent creation #1512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
key1989han wants to merge 1 commit into from
Closed

fix: fix(mcp): restrict automatic agent creation #1512

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions fix.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
# Fix for #1503

fix(mcp): restrict automatic agent creation
Comment on lines +1 to +3

@coderabbitai coderabbitai Bot Jul 17, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win

Document the precise agent-creation boundary.

This entry is too vague for #1503. State that only MEMANTO_DEFAULT_AGENT_ID may be auto-created; missing non-default agents must raise AgentNotFoundError and require explicit creation.

Suggested clarification 
 # Fix for `#1503`
 
 fix(mcp): restrict automatic agent creation
+
+Only the configured default agent may be auto-created. Non-default agents
+must already exist and otherwise raise `AgentNotFoundError`.
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
# Fix for #1503
fix(mcp): restrict automatic agent creation
# Fix for `#1503`
fix(mcp): restrict automatic agent creation
Only the configured default agent may be auto-created. Non-default agents
must already exist and otherwise raise `AgentNotFoundError`.
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@fix.md` around lines 1 - 3, Update the `#1503` changelog entry to explicitly
state that automatic creation is limited to MEMANTO_DEFAULT_AGENT_ID; missing
non-default agents must raise AgentNotFoundError and require explicit creation.

Loading