fix(migrate): keep OKF batches valid with long titles#1516
Open
jackmercy wants to merge 1 commit into
Open
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughOKF migration now truncates derived and explicit titles through shared limits, conditionally preserves overlong original titles in supporting data, and validates imported rows with a regression test. ChangesOKF title mapping
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
jackmercy
marked this pull request as ready for review
July 18, 2026 08:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MemoryRecord's 100-character limitMemoryRecordRoot cause and impact
map_okfbounded titles inferred from content, but forwarded explicit OKF titles unchanged.MemoryRecord.titlerejects values longer than 100 characters, and both batch clients construct everyMemoryRecordbefore storage starts.As a result, one foreign OKF entry with a 101-character title raises a validation error before any write and causes the migration runner to mark the entire batch as failed, including up to 99 otherwise-valid neighboring entries.
The mapper now shortens only the schema-bound title field and records the original value in supporting data, so the batch remains valid without silently discarding the source title.
Submission for #770.
Validation
uv run pytest -q(full suite passed; 24 live E2E tests skipped because no API key was configured)uv run ruff check .uv run mypy memantogit diff --checkSummary by CodeRabbit