Skip to content

Fix: Ambiguity Guard bypassed by common auxiliary verbs (is/are/was/were) #1520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ivegotahunnitonit wants to merge 1 commit into from
+11 −1
Closed

Fix: Ambiguity Guard bypassed by common auxiliary verbs (is/are/was/were) #1520

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion memanto/app/services/memory_parsing_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ class MemoryParsingService:
for pattern in [
r"https?://[^\s<>()\[\]{},;:\"']*[^\s<>()\[\]{},;:\"'.,!?]",
r"\b(?:endpoint|url|api key|path|email|phone|address)\b",
r"\b(?:is|are|was|were)\b",
]
]

Expand Down
11 changes: 11 additions & 0 deletions tests/test_memory_parsing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,3 +190,14 @@ def test_fuzzy_fallback_does_not_fire_on_unrelated_text():
parser.parse_memory(memory)

assert memory.type == "fact"


def test_ambiguity_guard_not_bypassed_by_auxiliary_verbs():
parser = MemoryParsingService()

# Contains 'is' alongside a typo for a decision term
memory = make_memory("The project uses Django and it is maintained, and we decded on Postgres")

parser.parse_memory(memory)

assert memory.type == "decision"
Loading