[Fix] _isFirstCreation from #94 causing duplicate field creations #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing duplicate field creations Adding logs in Start, OnEnable and InitProcess reveals that in some cases InitProcess is called twice. Thus resulting in CreateNativeEdit also being called twice.
|
Unrelated, there is also an issue with the application focus causing the input fields to go readonly and disable text. Have not looked into it yet since I patched this on the app side of things for my project. Thought it would be good to let you guys know. Update: Created PR for this #112 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested and fixed on iOS.
Adding logs in Start, OnEnable and InitProcess reveals that in some cases InitProcess is called twice. Thus resulting in CreateNativeEdit also being called twice. Moving the input field position also reveals that multiple input fields where in fact created.
How I discovered / how to reproduce:
This is a strange flow but the only one I can find currently to reproduce the issue and verify it's fixed.