Add AlertScene
#299
Merged
Add AlertScene
#299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An empty block returns the default "OK" action. `AlertScene` and `presentAlert` now require the `actions` parameter; an empty closure provides the previous behavior.
stackotter
requested changes
Jan 5, 2026
Collaborator
stackotter
left a comment
stackotter
left a comment
There was a problem hiding this comment.
This will be handy to have around. I've requested a few changes, but for the most part you've implemented it very well 🙏
Sources/SwiftCrossUI/Environment/Actions/PresentAlertAction.swift
Outdated
Show resolved
Hide resolved
stackotter
previously approved these changes
Jan 5, 2026
Collaborator
|
Just did some local testing. It works with AppKitBackend, and GtkBackend. It crashes with UIKitBackend; WindowingExample crashes with Gtk3Backend for an unrelated reason (#308); now resolved by your #309 PR. WindowingExample crashes with WinUIBackend as soon as the windows appear, but I'm not sure why. I'm currently looking into whether it's related or not, but I'm having issues with my Windows VM. |
stackotter
approved these changes
Jan 9, 2026
Collaborator
stackotter
left a comment
stackotter
left a comment
There was a problem hiding this comment.
Looks good. I'll test locally and then merge if all goes well
Collaborator
|
Tested with all backends and all works well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AlertSceneis a scene that presents a whole-app modal alert (or the backend's closest approximation thereof). It behaves similarly toView.alert(_:isPresented:actions:), but isn't attached to any one window.