Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chainlink oracles #1

Merged
merged 89 commits into from
Oct 16, 2023
Merged

Chainlink oracles #1

merged 89 commits into from
Oct 16, 2023

Conversation

MathisGD
Copy link
Contributor

@MathisGD MathisGD commented Sep 5, 2023

Handles notably these cases (let's say that our pair is A/B):

  • A/B is a feed (typically, stETH/ETH).
  • B/A is a feed (typically, USDC/ETH).
  • A/C and B/C are feeds (typically, stETH/ETH and USDC/ETH).
  • A/C, C/D and B/D are feeds (typically, WBTC/BTC, BTC/USD, USDC/USD).
  • A/D, and B/C, C/D are feeds (typically, USDC/USD, WBTC/BTC, BTC/USD).
  • A/C, C/D and B/E, E/D are feeds.
  • A/C and C/B are feeds (typically, WBTC/BTC and BTC/ETH).
  • and some other cases...

We are missing the feature of oracles that price tokens that have an exchange rate against a well-known token, like sDAI. This is implemented in #7 (not ready for onchain team review yet).

@MathisGD MathisGD self-assigned this Sep 5, 2023
src/chainlink/Oracle.sol Outdated Show resolved Hide resolved
@MathisGD MathisGD changed the title Chainlink oracles General Chainlink oracles Sep 6, 2023
src/chainlink/libraries/DataFeedLib.sol Outdated Show resolved Hide resolved
test/chainlink/OracleTest.sol Outdated Show resolved Hide resolved
src/chainlink/Oracle.sol Outdated Show resolved Hide resolved
@MathisGD MathisGD dismissed stale reviews from Jean-Grimal and Rubilmax via 34b30d7 October 16, 2023 07:56
@MathisGD MathisGD requested a review from Jean-Grimal October 16, 2023 08:01
@MathisGD MathisGD merged commit 62556bc into main Oct 16, 2023
@MathisGD MathisGD deleted the feat/chainlink branch October 16, 2023 09:21
@MerlinEgalite MerlinEgalite mentioned this pull request Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants