fix(oracle): require vault conversion not zero #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rubilmax
requested review from
QGarchery,
MerlinEgalite,
MathisGD and
Jean-Grimal
There was a problem hiding this comment.
Perhaps you could link this issue as well? https://github.com/cantinasec/review-morpho-blue-1/issues/71
Rubilmax
commented
Oct 27, 2023
MerlinEgalite
previously approved these changes
Oct 27, 2023
QGarchery
requested changes
Oct 30, 2023
|
@QGarchery so we acknowledge the issue? |
|
I'm in favor of acknowledging and this one can be fixed (no strong opinion here) |
Rubilmax
force-pushed
the
fix/vault-conversion-zero
branch
from
6bd5453 to
0a04fa2
Compare
MerlinEgalite
previously approved these changes
Nov 6, 2023
MerlinEgalite
approved these changes
Nov 6, 2023
QGarchery
approved these changes
Nov 7, 2023
Jean-Grimal
approved these changes
Nov 7, 2023
|
Shit this branch was not pointing to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vaultConversionSample!= 0 at construction #30