Alternative oracle to avoid overflows #37
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QGarchery
requested review from
MathisGD,
a team,
Rubilmax,
MerlinEgalite and
Jean-Grimal
and removed request for
a team
| Quantity memory base = Quantity(denominatorSample, DENOMINATOR_TOKEN_DECIMALS); | ||
| base = BASE_FEED_2.convert(base, BASE_TOKEN_2_DECIMALS); | ||
| base = BASE_FEED_1.convert(base, BASE_TOKEN_1_DECIMALS); | ||
| base.amount = address(VAULT) == address(0) ? base.amount : VAULT.convertToShares(base.amount); |
There was a problem hiding this comment.
aren't we loosing precision here if base.amount is too low?
| AggregatorV3Interface quoteFeed2, | ||
| uint256 quoteToken2Decimals, | ||
| uint256 denominatorTokenDecimals | ||
| ) { |
There was a problem hiding this comment.
we'll need to update it with the require we added in the other oracle I think
|
|
||
| /// @inheritdoc IOracle | ||
| function price() external view returns (uint256) { | ||
| uint256 denominatorSample = 10 ** DENOMINATOR_TOKEN_DECIMALS; |
There was a problem hiding this comment.
could be an immutable
|
|
||
| import {ErrorsLib} from "./ErrorsLib.sol"; | ||
|
|
||
| struct Quantity { |
There was a problem hiding this comment.
maybe we should specify what decimals are we talking about, the feed? The token?
|
Closing in favor of #36. The idea is still interesting and could be used for a future version of the oracle |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the third proposition in #15 (comment). The idea is to use a sample amount, and to only convert between amounts, in order to avoid multiplication overflow.
Remarks:
price()function, but could be set at deployment insteadfeed.decimals()in the Chainlink library