vault as loan asset #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MathisGD
commented
Feb 15, 2024
MathisGD
commented
Feb 15, 2024
MathisGD
commented
Feb 15, 2024
MerlinEgalite
requested changes
Feb 15, 2024
Co-authored-by: Romain Milon <[email protected]> Co-authored-by: Merlin Egalite <[email protected]> Signed-off-by: MathisGD <[email protected]>
Jean-Grimal
requested changes
Feb 15, 2024
Signed-off-by: MathisGD <[email protected]>
Jean-Grimal
previously approved these changes
Feb 15, 2024
|
formatting issue :) |
MerlinEgalite
requested changes
Feb 15, 2024
QGarchery
reviewed
Feb 15, 2024
QGarchery
reviewed
Feb 15, 2024
QGarchery
previously approved these changes
Feb 15, 2024
|
@MathisGD can you just format pls? |
MathisGD
dismissed stale reviews from Rubilmax, QGarchery, MerlinEgalite, and Jean-Grimal
The base branch was changed.
MerlinEgalite
previously approved these changes
Mar 5, 2024
Rubilmax
previously approved these changes
Mar 5, 2024
QGarchery
previously approved these changes
Mar 5, 2024
Jean-Grimal
previously approved these changes
Mar 5, 2024
Co-authored-by: Quentin Garchery <[email protected]> Signed-off-by: MathisGD <[email protected]>
MathisGD
dismissed stale reviews from Jean-Grimal, QGarchery, Rubilmax, and MerlinEgalite
via
2ce0440
MathisGD
requested review from
Rubilmax,
MerlinEgalite,
Jean-Grimal and
QGarchery
Jean-Grimal
approved these changes
Mar 5, 2024
QGarchery
approved these changes
Mar 5, 2024
Jean-Grimal
approved these changes
Mar 5, 2024
MerlinEgalite
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support ERC4626 as quote (= loan asset).
We don't discuss here the potential economic risks of using a 4626 as loan asset (potential price manipulations with donations etc), this will be an other project (starting next week).