Various improvements to wstETH adapter #83
Conversation
MerlinEgalite
requested review from
a team,
adhusson,
Rubilmax,
QGarchery,
MathisGD and
Jean-Grimal
and removed request for
a team
src/wsteth-exchange-rate-adapter/WstEthStEthExchangeRateChainlinkAdapter.sol
Outdated
Show resolved
Hide resolved
src/wsteth-exchange-rate-adapter/interfaces/MinimalAggregatorV3Interface.sol
Outdated
Show resolved
Hide resolved
src/wsteth-exchange-rate-adapter/WstEthStEthExchangeRateChainlinkAdapter.sol
Show resolved
Hide resolved
src/wsteth-exchange-rate-adapter/interfaces/MinimalAggregatorV3Interface.sol
Show resolved
Hide resolved
Co-authored-by: MathisGD <[email protected]> Signed-off-by: Merlin Egalite <[email protected]>
QGarchery
changed the title
…s/morpho-blue-oracles into refactor/various-improvements
src/wsteth-exchange-rate-adapter/WstEthStEthExchangeRateChainlinkAdapter.sol
Outdated
Show resolved
Hide resolved
|
I'm wondering if it makes sense to drop everywhere the reference to Chainlink everywhere and just use the "Morpho" terms. Like Morpho Adapter, Morpho Oracle and so on. Those will be "inspired" to the Chainlink version in the sense that you (Morpho) have agreed that their interface is a "standard de facto" for the function signatures for an oracle. |
That's something we thought about, but ditched because if in the future we develop an other oracle (for uniswap for example), it will be better to have a more specific name for this one. "Chainlink" isn't perfect, because it's only about its interface, but that's the best compromised we found. |
…r/various-improvements
…nto refactor/various-improvements
Fixes: