feat(readme): explaining the oracle creation from the factory #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MerlinEgalite
requested review from
a team,
adhusson,
Rubilmax,
QGarchery,
MathisGD and
Jean-Grimal
and removed request for
a team
MerlinEgalite
requested changes
Mar 6, 2024
Co-authored-by: Merlin Egalite <[email protected]> Signed-off-by: Reppelin Tom <[email protected]>
Co-authored-by: Merlin Egalite <[email protected]> Signed-off-by: Reppelin Tom <[email protected]>
Co-authored-by: Merlin Egalite <[email protected]> Signed-off-by: Reppelin Tom <[email protected]>
Co-authored-by: Merlin Egalite <[email protected]> Signed-off-by: Reppelin Tom <[email protected]>
Co-authored-by: Merlin Egalite <[email protected]> Signed-off-by: Reppelin Tom <[email protected]>
Rubilmax
reviewed
Mar 6, 2024
Co-authored-by: Romain Milon <[email protected]> Signed-off-by: Reppelin Tom <[email protected]>
Co-authored-by: Romain Milon <[email protected]> Signed-off-by: Reppelin Tom <[email protected]>
Co-authored-by: Romain Milon <[email protected]> Signed-off-by: Reppelin Tom <[email protected]>
MerlinEgalite
previously approved these changes
Mar 6, 2024
MathisGD
reviewed
Mar 7, 2024
| @@ -18,32 +18,98 @@ This oracle handles the following cases among others (let's say that our pair is | |||
| - A/C and C/B are feeds (typically, WBTC/BTC and BTC/ETH). | |||
| - A'/C and B/C are feeds, and there is an exchange rate between A and A'. (typically A=sDAI and A'=DAI). | |||
QGarchery
previously approved these changes
Mar 7, 2024
Co-authored-by: Quentin Garchery <[email protected]> Signed-off-by: Reppelin Tom <[email protected]>
Co-authored-by: Quentin Garchery <[email protected]> Signed-off-by: Reppelin Tom <[email protected]>
MerlinEgalite
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the readme, thanks to the
MorphoChainlinkOracleV2Factory