u/MarkusMichaelRau/Modifications handle an exception that gets raised if the kd-tree doesn't find a pair#9
Open
MarkusMichaelRau wants to merge 1 commit intomorriscb:masterfrom
Open
Conversation
… no pair is found.
morriscb
approved these changes
Oct 27, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modifications handle an exception that gets raised if the KD-tree doesn't find a pair between unknown and reference object within the annulus. I also added a small check in the initialization of PairMaker to make sure the r_mins and r_maxes get put into a list even if they are specified as numbers.
Please let me know if these changes make sense.