Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type check issue with device train microbatch size #3349

Merged
merged 1 commit into from
May 31, 2024
Merged

Fix type check issue with device train microbatch size #3349

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion composer/trainer/trainer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,7 +295,7 @@ def _get_initial_device_train_microbatch_size(
"`device_train_microbatch_size='auto'` requires the `state.train_dataloader` to have a `batch_size` attribute.",
) from e
return batch_size
elif isinstance(device_train_microbatch_size, Union[int, float]):
elif isinstance(device_train_microbatch_size, (int, float)):
return device_train_microbatch_size
else:
raise ValueError("device_train_microbatch_size must be an int or ``'auto'``")
Expand Down
Loading