Don't overwrite existing excepthook in mlflow logger #3672
Closed
+9
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
irenedea
reviewed
Oct 21, 2024
| @@ -322,7 +322,13 @@ def init(self, state: State, logger: Logger) -> None: | |||
| self.run_name += f'-rank{dist.get_global_rank()}' | |||
|
|
|||
| # Register the global exception handler so that uncaught exception is tracked. | |||
| sys.excepthook = self._global_exception_handler | |||
| original_excepthook = sys.excepthook | |||
There was a problem hiding this comment.
alternatively you could save original_excepthook on self (i.e. self.original_excepthook), so you don't need to use a lambda below
There was a problem hiding this comment.
yeah i think lambda is ok. could've also done functools.partial. don't feel particularly strongly between any of those options
|
Closing in favor of #3675 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The previous PR that added exception hook handling to mlflow just blindly overwrites the existing excepthook. This PR changes that to use the existing excepthook and just add what the mlflow logger needs.
Before:
llama-7b-commits-6-D3ipHw(exception is not rich formatted, because systemwide excepthook is not triggered)After:
llama-7b-commits-11-3KdS8L(exception is rich formatted, because systemwide excepthook is triggered)