Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update checkpoint tests to use new version 0.26.0 #3683

Merged
merged 3 commits into from
Oct 31, 2024
Merged

Update checkpoint tests to use new version 0.26.0 #3683

merged 3 commits into from
Oct 31, 2024

Conversation

irenedea
Copy link
Contributor

@irenedea irenedea commented Oct 26, 2024 •
edited
Loading

What does this PR do?

daily tests pass: https://github.com/mosaicml/composer/actions/runs/11601544804

What issue(s) does this change relate to?

Before submitting

  • Have you read the contributor guidelines?
  • Is this change a documentation change or typo fix? If so, skip the rest of this checklist.
  • Was this change discussed/approved in a GitHub issue first? It is much more likely to be merged if so.
  • Did you update any related docs and document your change?
  • Did you update any related tests and add any new tests related to your change? (see testing)
  • Did you run the tests locally to make sure they pass?
  • Did you run pre-commit on your change? (see the pre-commit section of prerequisites)

@irenedea irenedea enabled auto-merge (squash) October 28, 2024 04:56
@irenedea irenedea requested review from mvpatel2000, j316chuck, dakinggg and a team October 28, 2024 04:56
snarayan21
snarayan21 previously requested changes Oct 28, 2024
View reviewed changes
tests/trainer/test_fsdp_checkpoint.py Outdated Show resolved Hide resolved
@irenedea irenedea disabled auto-merge October 28, 2024 18:55
@irenedea irenedea force-pushed the update-checkpoint-tests-0.26.0 branch from b599d50 to f68c5a3 Compare October 30, 2024 20:58
@irenedea
Copy link
Contributor Author

new daily tests pass: https://github.com/mosaicml/composer/actions/runs/11601544804

@irenedea irenedea requested a review from snarayan21 October 31, 2024 00:18
@irenedea irenedea enabled auto-merge (squash) October 31, 2024 00:19
@dakinggg dakinggg dismissed snarayan21’s stale review October 31, 2024 00:19

dismissing because its been addressed

@irenedea irenedea merged commit eb51f08 into main Oct 31, 2024
35 checks passed
@irenedea irenedea deleted the update-checkpoint-tests-0.26.0 branch October 31, 2024 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dakinggg dakinggg dakinggg approved these changes

@mvpatel2000 mvpatel2000 Awaiting requested review from mvpatel2000

@j316chuck j316chuck Awaiting requested review from j316chuck

@snarayan21 snarayan21 Awaiting requested review from snarayan21

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@irenedea @mvpatel2000 @snarayan21 @dakinggg