Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrated all possible assets from GCP to repo #3717

Merged
merged 2 commits into from
Nov 22, 2024

Conversation

ethantang-db
Copy link
Contributor

@ethantang-db ethantang-db commented Nov 19, 2024

What does this PR do?

After the deletion of mosaic's assets on GCS, this PR is an attempt to restore most of the assets that were removed.

Some assets were not recovered though as archive never managed to store them. These includes

https://storage.googleapis.com/docs.mosaicml.com/images/methods/sam.png
https://storage.googleapis.com/docs.mosaicml.com/images/methods/layer-freezing.png
https://storage.googleapis.com/docs.mosaicml.com/images/methods/gated_linear_units.png
https://storage.googleapis.com/docs.mosaicml.com/images/methods/swa.png
https://storage.googleapis.com/docs.mosaicml.com/images/tutorials/launch_instance.png
https://storage.googleapis.com/docs.mosaicml.com/images/tutorials/configure_ebs.png
https://storage.googleapis.com/docs.mosaicml.com/images/profiler/analyzing_traces-trainer_events.png
https://storage.googleapis.com/docs.mosaicml.com/images/profiler/analyzing_traces-dataloader.png
https://storage.googleapis.com/docs.mosaicml.com/images/profiler/analyzing_traces-system_metrics.png
https://storage.googleapis.com/docs.mosaicml.com/images/profiler/analyzing_traces-torch.png
https://storage.googleapis.com/docs.mosaicml.com/images/profiler/analyzing_traces-composer.png
https://storage.googleapis.com/docs.mosaicml.com/images/profiler/analying_traces-example_pre.png
https://storage.googleapis.com/docs.mosaicml.com/images/profiler/analyzing_traces-example_post.png
https://storage.googleapis.com/docs.mosaicml.com/images/training_loop.png

Pour one out for those image asset homies

Before submitting

  • Have you read the contributor guidelines?
  • Is this change a documentation change or typo fix? If so, skip the rest of this checklist.
  • Was this change discussed/approved in a GitHub issue first? It is much more likely to be merged if so.
  • Did you update any related docs and document your change?
  • Did you update any related tests and add any new tests related to your change? (see testing)
  • Did you run the tests locally to make sure they pass?
  • Did you run pre-commit on your change? (see the pre-commit section of prerequisites)

@ethantang-db ethantang-db requested review from a team as code owners November 19, 2024 20:42
@ethantang-db ethantang-db force-pushed the ethantang-db/fix_image_assets branch from 06fa802 to c79a3db Compare November 20, 2024 01:29
@ethantang-db ethantang-db merged commit b8cc29e into main Nov 22, 2024
14 checks passed
@ethantang-db ethantang-db deleted the ethantang-db/fix_image_assets branch November 22, 2024 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants