Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add checkpoint BC tests for 0.27.0 and 0.28.0 #3735

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

snarayan21
Copy link
Contributor

@snarayan21 snarayan21 commented Dec 5, 2024

What does this PR do?

As title. Adds for 0.27.0 as well since this was not done upon release.

Daily tests passed: https://github.com/mosaicml/composer/actions/runs/12184347841

What issue(s) does this change relate to?

Before submitting

  • Have you read the contributor guidelines?
  • Is this change a documentation change or typo fix? If so, skip the rest of this checklist.
  • Was this change discussed/approved in a GitHub issue first? It is much more likely to be merged if so.
  • Did you update any related docs and document your change?
  • Did you update any related tests and add any new tests related to your change? (see testing)
  • Did you run the tests locally to make sure they pass?
  • Did you run pre-commit on your change? (see the pre-commit section of prerequisites)

@snarayan21 snarayan21 marked this pull request as draft December 5, 2024 16:53
@snarayan21 snarayan21 marked this pull request as ready for review December 5, 2024 17:50
@snarayan21 snarayan21 requested review from mvpatel2000, dakinggg, bigning and j316chuck and removed request for mvpatel2000 December 5, 2024 17:50
@snarayan21 snarayan21 enabled auto-merge (squash) December 5, 2024 17:52
Copy link
Contributor

@j316chuck j316chuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for patching 0.27.0 ❤️

@snarayan21 snarayan21 merged commit 06fb4a8 into main Dec 5, 2024
34 checks passed
@snarayan21 snarayan21 deleted the saaketh/fsdp_compat_2728 branch December 5, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants