README: change intended location of .env file from project root to working directory#815
Merged
motdotla merged 2 commits intomotdotla:masterfrom Feb 22, 2024
stefanneuhaus:readme_working-directory
Merged
README: change intended location of .env file from project root to working directory#815motdotla merged 2 commits intomotdotla:masterfrom stefanneuhaus:readme_working-directory
motdotla merged 2 commits intomotdotla:masterfrom
stefanneuhaus:readme_working-directory
Conversation
…rking directory of process
Owner
|
i understand. i'm just concerned this might cause more confusion for the typical path - which is can you describe the situation you were in that it was confusing? was it a monorepo? |
Contributor
Author
|
I agree, having a simple introductory example is nice. In "my" case an undergraduate of mine spent hours analyzing the issue for her project with a project structure like |
Owner
|
can you change the text to something like: |
Rework explanation
Contributor
Author
|
I updated the text accordingly. |
Owner
|
thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Although this is correctly explained further down in the section on Config options, being not 100% correct in this "Hello World" example can cause unnecessary confusion in the first place.