fix(ci): Ruff isort known-first-party (unblock CI & deploy) - #311
Merged
Conversation
coaching/pyproject.toml lacked [tool.ruff.lint.isort] known-first-party, so Ruff treated coaching.* as third-party and failed I001 (e.g. unified_ai_engine.py), breaking CI/CD and Deploy Dev after #310. Add known-first-party matching repo root; apply ruff check --fix across coaching/ for consistent import blocks. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cause
GitHub CI/CD Pipeline and Deploy Dev failed on
ruff checkwith I001 onunified_ai_engine.pyafter merging #310.Ruff resolves
coaching/pyproject.tomlfor files undercoaching/. That file had no[tool.ruff.lint.isort] known-first-party, socoaching.*imports were sorted as third-party relative tostructlog/pydantic, producing invalid import blocks.Fix
known-first-party = ["coaching", "shared"]tocoaching/pyproject.toml(aligned with repo rootpyproject.toml).ruff check coaching/ --fixso the tree matches the corrected isort rules (~199 I001 fixes).Verification
ruff==0.8.4ruff check coaching/ shared/— cleanpytest coaching/tests/unit/application/ai_engine/test_llm_json_schema_adaptation.py— 5 passedUnblocks redeploy to dev.