Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds fields for feedback on MoveGroupSequence action progress #176

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Adds fields for feedback on MoveGroupSequence action progress #176

wants to merge 4 commits into from

Conversation

rr-tom-noble
Copy link

@rr-tom-noble rr-tom-noble commented Apr 29, 2024 •
edited
Loading

@rr-tom-noble rr-tom-noble mentioned this pull request Apr 29, 2024
Open
@rr-tom-noble rr-tom-noble changed the title Adds fields for feedback on MotionGroupSequence action progress Adds fields for feedback on MoveGroupSequence action progress Apr 29, 2024
@rr-tom-noble
Copy link
Author

@rhaschke Would you mind running the workflows?

@rhaschke
Copy link
Contributor

@rhaschke Would you mind running the workflows?

Unfortunately, I don't yet have permissions again. OSRF withdraw our admin permissions on all ros-planning repositories and we had to migrate to the organization moveit.

@rr-tom-noble
Copy link
Author

@rhaschke
Do you know who would still have permissions to run the workflows? Someone from the OSRF?

@rhaschke
Copy link
Contributor

I regained permissions.

@rr-tom-noble
Copy link
Author

@rhaschke Thanks for running the checks. Would you be happy to merge this PR, or should I make the additional moveit changes first?

rhaschke
rhaschke requested changes May 18, 2024
View reviewed changes
Copy link
Contributor

@rhaschke rhaschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to suggest a few changes.

action/MoveGroupSequence.action Outdated Show resolved Hide resolved
@rr-tom-noble rr-tom-noble requested a review from rhaschke May 20, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhaschke rhaschke rhaschke approved these changes

@henningkayser henningkayser henningkayser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rr-tom-noble @rhaschke @henningkayser