Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1923840 - Searching for bugs containing a mentor times out (504 Gateway timeout) #2343

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

dklawren
Copy link
Collaborator

When selecting a search include Mentors, it is using a non-existent function _commenter_pronoun and needs to instead use _contact_pronoun. This was missed in an earlier commit back porting pronoun support to more places.

@dklawren dklawren requested a review from cgsheeh October 11, 2024 17:00
Copy link
Collaborator

@cgsheeh cgsheeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does BMO/Perl have linters we could enable in CI to catch things like this?

@dklawren
Copy link
Collaborator Author

Does BMO/Perl have linters we could enable in CI to catch things like this?

It does but for some reason does not catch undefined functions :(

@dklawren dklawren merged commit d4a8f03 into mozilla-bteam:master Oct 15, 2024
17 checks passed
@dklawren dklawren deleted the 1923840 branch October 15, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants