Bug 1928083 - Bugzilla’s emojis are displayed on the bottom of the page when activated creating a new scroll bar #2351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of the page when activated creating a new scroll bar
dklawren
approved these changes
Oct 30, 2024
|
@dklawren Thank you for your quick review 🙏🏼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug 1928083 - Bugzilla’s emojis are displayed on the bottom of the page when activated creating a new scroll bar
The cause is due to a change in page layout (fixed global header) in #2334, but reverting the change would rather introduce other problems (I don’t remember exactly, but I saw several problems while working on mobile optimization).
The solution is to detect the CSS Anchor Positioning API, which is not yet implemented in Firefox and Safari, and fall back to the legacy implementation if the API is not available.
This also fixes the anchor positioning itself. My initial implementation hardcoded
anchor-namein CSS, but it doesn’t work well because there are usually multiple comments in a bug, andanchor-nameneeds to be unique for each. Not sure why it wasn’t caught earlier.I’ve tested this fix with Firefox, Chrome and Safari.