Skip to content

github: add GitHubAPI, GitHubAPIClient classes (bug 1989637)#536

Merged
zzzeid merged 1 commit intozeid/bug-1989635-github-pr-pilotfrom
zeid/bug-1989637-github-api-client
Oct 22, 2025
Merged

github: add GitHubAPI, GitHubAPIClient classes (bug 1989637)#536
zzzeid merged 1 commit intozeid/bug-1989635-github-pr-pilotfrom
zeid/bug-1989637-github-api-client

Conversation

@zzzeid
Copy link
Copy Markdown
Contributor

@zzzeid zzzeid commented Sep 19, 2025

  • add GitHubAPI class
  • add GitHubAPIClient class
  • move "get token" functionality to GitHubAPI class
  • fix failing test_GitSCM_push_get_github_token

Comment thread src/lando/utils/github.py
@zzzeid zzzeid changed the base branch from main to zeid/bug-1989635-github-pr-pilot October 16, 2025 13:25
@zzzeid zzzeid force-pushed the zeid/bug-1989637-github-api-client branch 3 times, most recently from d1060ba to 73a4727 Compare October 21, 2025 17:01
@zzzeid zzzeid marked this pull request as ready for review October 21, 2025 18:13
@zzzeid zzzeid marked this pull request as draft October 21, 2025 18:22
- add GitHubAPI class
- add GitHubAPIClient class
- move "get token" functionality to GitHubAPI class
- fix failing test_GitSCM_push_get_github_token
@zzzeid zzzeid force-pushed the zeid/bug-1989637-github-api-client branch from 73a4727 to af52580 Compare October 21, 2025 19:50
@zzzeid zzzeid marked this pull request as ready for review October 21, 2025 19:51
@zzzeid zzzeid requested a review from shtrom October 21, 2025 19:59
return self.url.removesuffix(".git")

@property
def _github_repo_org(self) -> str | None:
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would no longer be needed with #604.

Copy link
Copy Markdown
Member

@shtrom shtrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zzzeid zzzeid merged commit a54f526 into zeid/bug-1989635-github-pr-pilot Oct 22, 2025
1 check passed
@zzzeid zzzeid deleted the zeid/bug-1989637-github-api-client branch October 22, 2025 13:04
zzzeid added a commit that referenced this pull request Oct 27, 2025
- add GitHubAPI class
- add GitHubAPIClient class
- move "get token" functionality to GitHubAPI class
- fix failing test_GitSCM_push_get_github_token
zzzeid added a commit that referenced this pull request Oct 28, 2025
- add GitHubAPI class
- add GitHubAPIClient class
- move "get token" functionality to GitHubAPI class
- fix failing test_GitSCM_push_get_github_token
zzzeid added a commit that referenced this pull request Oct 28, 2025
- add GitHubAPI class
- add GitHubAPIClient class
- move "get token" functionality to GitHubAPI class
- fix failing test_GitSCM_push_get_github_token
shtrom pushed a commit that referenced this pull request Oct 31, 2025
- add GitHubAPI class
- add GitHubAPIClient class
- move "get token" functionality to GitHubAPI class
- fix failing test_GitSCM_push_get_github_token
zzzeid added a commit that referenced this pull request Nov 6, 2025
- add GitHubAPI class
- add GitHubAPIClient class
- move "get token" functionality to GitHubAPI class
- fix failing test_GitSCM_push_get_github_token
zzzeid added a commit that referenced this pull request Nov 6, 2025
- add GitHubAPI class
- add GitHubAPIClient class
- move "get token" functionality to GitHubAPI class
- fix failing test_GitSCM_push_get_github_token
zzzeid added a commit that referenced this pull request Nov 20, 2025
- add GitHubAPI class
- add GitHubAPIClient class
- move "get token" functionality to GitHubAPI class
- fix failing test_GitSCM_push_get_github_token
zzzeid added a commit that referenced this pull request Nov 24, 2025
- add GitHubAPI class
- add GitHubAPIClient class
- move "get token" functionality to GitHubAPI class
- fix failing test_GitSCM_push_get_github_token
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants