pull_request: add more functionality to end points and ui (bug 1991125)#607
Merged
zzzeid merged 16 commits intozeid/bug-1989635-github-pr-pilotfrom Oct 28, 2025
Conversation
zzzeid
force-pushed
the
zeid/bug-1991125-landing-job-backend-frontend
branch
from
fd214e7 to
464c6a0
Compare
zzzeid
force-pushed
the
zeid/bug-1991125-new-landing-job-endpoint
branch
from
a46f432 to
4292fac
Compare
zzzeid
force-pushed
the
zeid/bug-1991125-landing-job-backend-frontend
branch
from
464c6a0 to
c9e89e8
Compare
zzzeid
force-pushed
the
zeid/bug-1991125-new-landing-job-endpoint
branch
from
4292fac to
0284b40
Compare
zzzeid
force-pushed
the
zeid/bug-1991125-landing-job-backend-frontend
branch
from
c9e89e8 to
f53b84c
Compare
zzzeid
force-pushed
the
zeid/bug-1991125-new-landing-job-endpoint
branch
from
0284b40 to
54e730a
Compare
zzzeid
force-pushed
the
zeid/bug-1991125-landing-job-backend-frontend
branch
from
f53b84c to
f0579e6
Compare
zzzeid
force-pushed
the
zeid/bug-1991125-new-landing-job-endpoint
branch
from
54e730a to
c5b89cc
Compare
- add GitHubAPI class - add GitHubAPIClient class - move "get token" functionality to GitHubAPI class - fix failing test_GitSCM_push_get_github_token
zzzeid
force-pushed
the
zeid/bug-1991125-new-landing-job-endpoint
branch
from
c5b89cc to
9e76920
Compare
zzzeid
force-pushed
the
zeid/bug-1991125-landing-job-backend-frontend
branch
3 times, most recently
from
85dade5 to
eb53a97
Compare
zzzeid
force-pushed
the
zeid/bug-1991125-landing-job-backend-frontend
branch
from
eb53a97 to
1c63a7a
Compare
shtrom
reviewed
Oct 22, 2025
shtrom
requested changes
Oct 22, 2025
Member
shtrom
left a comment
shtrom
left a comment
There was a problem hiding this comment.
I don't think we should use Django models directly in the github utility classes. Perhaps we'd need a separate util to give us the status of a PR when needed.
A few questions otherwise, for clarification (disguised as nits).
zzzeid
force-pushed
the
zeid/bug-1991125-new-landing-job-endpoint
branch
from
9e76920 to
44f0c25
Compare
Base automatically changed from
zeid/bug-1991125-new-landing-job-endpoint
to
zeid/bug-1989635-github-pr-pilot
October 22, 2025 13:42
…b.com:mozilla-conduit/lando into zeid/bug-1991125-landing-job-backend-frontend
zzzeid
commented
Oct 23, 2025
zzzeid
commented
Oct 27, 2025
zzzeid
force-pushed
the
zeid/bug-1989635-github-pr-pilot
branch
2 times, most recently
from
a35e7a0 to
46cc0be
Compare
shtrom
approved these changes
Oct 27, 2025
Member
shtrom
left a comment
shtrom
left a comment
There was a problem hiding this comment.
r+ with nit: we can remove the repo dependency from the PullRequest. See suggested changes in comments.
| from simple_github import AppAuth, AppInstallationAuth | ||
|
|
||
| from lando.main.models.repo import Repo | ||
|
|
Member
There was a problem hiding this comment.
nit
Suggested change
| from lando.main.models.repo import Repo | |
Contributor
Author
There was a problem hiding this comment.
Hmm not sure what this comment is? This is handled by ruff anyway.
zzzeid
added a commit
that referenced
this pull request
Oct 28, 2025
…5) (#607) - add and update pull request API views - add Revision.pull_number field - add pull request functionality to Stack.js - update pull request template - add helper methods and properties in github utils
zzzeid
added a commit
that referenced
this pull request
Oct 28, 2025
…5) (#607) - add and update pull request API views - add Revision.pull_number field - add pull request functionality to Stack.js - update pull request template - add helper methods and properties in github utils
shtrom
pushed a commit
that referenced
this pull request
Oct 31, 2025
…5) (#607) - add and update pull request API views - add Revision.pull_number field - add pull request functionality to Stack.js - update pull request template - add helper methods and properties in github utils
zzzeid
added a commit
that referenced
this pull request
Nov 6, 2025
…5) (#607) - add and update pull request API views - add Revision.pull_number field - add pull request functionality to Stack.js - update pull request template - add helper methods and properties in github utils
zzzeid
added a commit
that referenced
this pull request
Nov 6, 2025
…5) (#607) - add and update pull request API views - add Revision.pull_number field - add pull request functionality to Stack.js - update pull request template - add helper methods and properties in github utils
zzzeid
added a commit
that referenced
this pull request
Nov 20, 2025
…5) (#607) - add and update pull request API views - add Revision.pull_number field - add pull request functionality to Stack.js - update pull request template - add helper methods and properties in github utils
zzzeid
added a commit
that referenced
this pull request
Nov 24, 2025
…5) (#607) - add and update pull request API views - add Revision.pull_number field - add pull request functionality to Stack.js - update pull request template - add helper methods and properties in github utils
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.