GitHubAPIClient: scope GET requests to the chosen repo#608
Merged
shtrom merged 7 commits intoOct 29, 2025
Conversation
zzzeid
force-pushed
the
zeid/bug-1989963-pr-view
branch
4 times, most recently
from
60d0b63 to
856dffe
Compare
- add GitHubAPI class - add GitHubAPIClient class - move "get token" functionality to GitHubAPI class - fix failing test_GitSCM_push_get_github_token
zzzeid
force-pushed
the
zeid/bug-1989963-pr-view
branch
from
856dffe to
456ba02
Compare
shtrom
force-pushed
the
no-bug/scope-get-to-repo
branch
from
c232a88 to
81d2887
Compare
shtrom
changed the base branch from
zeid/bug-1989963-pr-view
to
no-bug/github-api-url-parsing
shtrom
changed the base branch from
no-bug/github-api-url-parsing
to
zeid/bug-1989963-pr-view
Member
Author
|
This will need some conflict resolution after #604 is merged. |
zzzeid
force-pushed
the
zeid/bug-1989963-pr-view
branch
from
456ba02 to
69f1574
Compare
Base automatically changed from
zeid/bug-1989963-pr-view
to
zeid/bug-1989635-github-pr-pilot
October 22, 2025 13:29
zzzeid
previously requested changes
Oct 24, 2025
| Return: | ||
| dist | list: decoded JSON from the response | ||
| """ | ||
| result = self.client.get(f"{self.repo_base_url}/{path}", *args, **kwargs) |
Contributor
There was a problem hiding this comment.
This was left out of this method in case there is a non-repo scoped URL that the client needs to access (e.g., repos, users, etc...)
I think there may be a different way to do this that doesn't preclude this ability in the future (e.g., adding self._get_repo method).
Member
Author
There was a problem hiding this comment.
Yep, _get_repo could work. I mainly want to avoid the duplication of the repo_base_url parameter everywhere if we can avoid it, as the Session already has this scope.
zzzeid
force-pushed
the
zeid/bug-1989635-github-pr-pilot
branch
4 times, most recently
from
1ede676 to
7c1d6a8
Compare
…' into no-bug/scope-get-to-repo
shtrom
force-pushed
the
no-bug/scope-get-to-repo
branch
from
14cb5c3 to
5f83909
Compare
shtrom
force-pushed
the
no-bug/scope-get-to-repo
branch
from
5f83909 to
56a2af8
Compare
shtrom
dismissed
zzzeid’s stale review
merged pr-pilot pr, reverted _get changes, added _repo_get instead
shtrom
commented
Oct 29, 2025
zzzeid
approved these changes
Oct 29, 2025
Contributor
zzzeid
left a comment
zzzeid
left a comment
There was a problem hiding this comment.
Approving this with the caveat about the one comment (re: _post method) which should be addressed before this is merged.
Co-authored-by: Zeid <2043828+zzzeid@users.noreply.github.com>
shtrom
added a commit
that referenced
this pull request
Oct 31, 2025
Co-authored-by: Zeid <zeid@mozilla.com>
zzzeid
added a commit
that referenced
this pull request
Nov 6, 2025
Co-authored-by: Zeid <zeid@mozilla.com>
zzzeid
added a commit
that referenced
this pull request
Nov 6, 2025
Co-authored-by: Zeid <zeid@mozilla.com>
zzzeid
added a commit
that referenced
this pull request
Nov 20, 2025
Co-authored-by: Zeid <zeid@mozilla.com>
zzzeid
added a commit
that referenced
this pull request
Nov 24, 2025
Co-authored-by: Zeid <zeid@mozilla.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.