landing_worker: add comment + close pr functionality (bug 1994736)#614
Merged
zzzeid merged 31 commits intozeid/bug-1989635-github-pr-pilotfrom Oct 28, 2025
Merged
Conversation
zzzeid
force-pushed
the
zeid/bug-1989960-modify-pr-api
branch
2 times, most recently
from
f0f00ea to
084b2a2
Compare
- add GitHubAPI class - add GitHubAPIClient class - move "get token" functionality to GitHubAPI class - fix failing test_GitSCM_push_get_github_token
zzzeid
force-pushed
the
zeid/bug-1989960-modify-pr-api
branch
2 times, most recently
from
3517928 to
947c93e
Compare
zzzeid
force-pushed
the
zeid/bug-1989960-modify-pr-api
branch
from
947c93e to
dea1b83
Compare
zzzeid
force-pushed
the
zeid/bug-1994736-close-comment-pr
branch
from
5db10b5 to
f3adbf2
Compare
zzzeid
force-pushed
the
zeid/bug-1994736-close-comment-pr
branch
from
f3adbf2 to
5f9c40d
Compare
shtrom
approved these changes
Oct 22, 2025
shtrom
reviewed
Oct 22, 2025
- add GitHubAPI class - add GitHubAPIClient class - move "get token" functionality to GitHubAPI class - fix failing test_GitSCM_push_get_github_token
- add pull request template - add pull request view - add pull request helper class - add pulls url
- add `PullRequestAPIView.get` endpoint - add placeholder for `LandingJobAPIView.post` endpoint - add `serialize` method to `PullRequest` class - update urls with above
…b.com:mozilla-conduit/lando into zeid/bug-1991125-landing-job-backend-frontend
shtrom
requested changes
Oct 27, 2025
Member
shtrom
left a comment
shtrom
left a comment
There was a problem hiding this comment.
Hum, no, the test still fails... 🤔 Could the pull_number be something else than null, but still invalid?
…d/bug-1989960-modify-pr-api
Contributor
Author
I think it's because I forgot to mark |
shtrom
approved these changes
Oct 27, 2025
…5) (#607) - add and update pull request API views - add Revision.pull_number field - add pull request functionality to Stack.js - update pull request template - add helper methods and properties in github utils
- add methods to open, close, and comment on pull requests
Base automatically changed from
zeid/bug-1989960-modify-pr-api
to
zeid/bug-1989635-github-pr-pilot
October 28, 2025 13:16
zzzeid
force-pushed
the
zeid/bug-1994736-close-comment-pr
branch
from
0433a8f to
34074e5
Compare
zzzeid
force-pushed
the
zeid/bug-1989635-github-pr-pilot
branch
from
a9a01e9 to
eb3ab82
Compare
…-close-comment-pr
zzzeid
force-pushed
the
zeid/bug-1994736-close-comment-pr
branch
from
a3b6da1 to
fbd254f
Compare
zzzeid
force-pushed
the
zeid/bug-1994736-close-comment-pr
branch
from
cfd1848 to
5b15cc7
Compare
This reverts commit cfd1848.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.