Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix console warning in views/Project #251

Closed

Conversation

uu1t
Copy link

@uu1t uu1t commented Oct 14, 2018

Fix #248.
Same as part of #79.

@eliperelman
Copy link
Contributor

I'm curious why the component is object. I'm also not convinced that the other patch that used object is correct either.

@fiennyangeln
Copy link
Contributor

fiennyangeln commented Oct 14, 2018

@eliperelman yup! I agree using object is misleading. I used it before after I read this https://material-ui.com/api/typography/ but I think I misinterpret the meaning 😅 . Hi @uu1t are you interested in fixing that one too? I guess the component props means what will be the HTML tag like "div" will map into <div ... /> and "span" will map into <span .. /> or a component

@djmitche
Copy link
Contributor

I'm closing this as stale. It can be re-opened, or a new version created, of course!

@djmitche djmitche closed this Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix warning in the console
4 participants