-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fxp 3678 update browsers on awfy #532
base: master
Are you sure you want to change the base?
Fxp 3678 update browsers on awfy #532
Conversation
remove geckoview remove safari remove chrome-m and add chromium-as-release rename Fenix label to Firefox remove chrome desktop test added linting
✅ Deploy Preview for firefox-performance-dashboard ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
thanks @Carla-Moz ! just some quick questions before i take a deeper look also curious how were the har files created/updated? that never happened for me (unless it was related to the yarn.lock changes, then nvm) |
Actually, I didn't mean to include |
@92kns And yes, I plan to fix the security concerns in a separate PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #532 +/- ##
==========================================
+ Coverage 85.42% 86.00% +0.57%
==========================================
Files 14 14
Lines 350 350
Branches 52 51 -1
==========================================
+ Hits 299 301 +2
+ Misses 46 44 -2
Partials 5 5 ☔ View full report in Codecov by Sentry. |
.circleci/config.yml
Outdated
@@ -23,7 +23,7 @@ jobs: | |||
command: yarn build | |||
name: Check build | |||
- run: | |||
command: yarn test:coverage | |||
command: yarn test:coverage -u |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not too familiar with this - what is/was the reason to do this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like I said in our previous, I was force updating the snapshots but I'll remove this because this should only be done locally.
also, could you please squash the commits? might be easiest to squash to 1-3 commits (up to you) and force push |
@Carla-Moz Revisiting the old ticket looks like we had this requirement I forgot to bring up again from https://bugzilla.mozilla.org/show_bug.cgi?id=1910645#c1 "We should also add a link to an FAQ (perhaps in the GitHub README) from the top of the page, and include a brief explainer of what we're showing. Something like "Using the most recent build available to us of the relevant browsers" and also touch on how/why we're building Chromium as release." could you look into adding something like that? |
Sure! First, do we already have the link to the FAQ? Second, I would need the answer to this question: how and why are we building Chromium as release? |
7d68928
to
3712e31
Compare
temporary fix for tests, will need new PR to handle test case revert test changes in perfherder.test.js changed perfherder.test.js updated cyan color Update config.yml Review yarn.lock to previous version temporary fix for tests, will need new PR to handle test cases
7d68928
to
90acbf7
Compare
This PR will replace Update browsers fix #530
Closes Jira issue Update browsers on AWFY FXP 3678
Note: For this review, I need help with test/config.test.js li14 test