Basic iOS widget. r=francisco #224
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcturus
reviewed
Sep 22, 2016
|
|
||
| class MagnetScanner: NSObject { | ||
| var scanner: MagnetScannerIOS.MagnetScanner!; | ||
| var callback: ((Dictionary<String, AnyObject>) -> Void)! |
There was a problem hiding this comment.
Do we need to save an instance of the callback?
| @@ -5,7 +5,7 @@ | |||
| <key>CFBundleDevelopmentRegion</key> | |||
| <string>en</string> | |||
| <key>CFBundleDisplayName</key> | |||
| <string>MagnetWidget</string> | |||
| <string>Magnet</string> | |||
There was a problem hiding this comment.
Can you change it to 'Project Magnet'
| @@ -54,7 +85,54 @@ class MagnetWidgetTableViewController: UITableViewController, NCWidgetProviding | |||
|
|
|||
| toDisplay.append(url); | |||
|
|
|||
| self.table.reloadData(); | |||
| // Get url metadata. | |||
| let metadataServer: String = "https://tengam.org/api/v1/metadata"; | |||
There was a problem hiding this comment.
Should we set this as a constant class attribute?
| let task = session.dataTaskWithRequest(request, completionHandler: { | ||
| (data, response, error) in | ||
| guard error == nil else { | ||
| print("Error: metadata server error", error); |
There was a problem hiding this comment.
Perhaps we should do debugPrint here too, I know those are proper errors, but just to keep user's console clean.
| # Uncomment this line to define a global platform for your project | ||
| # platform :ios, '9.0' | ||
|
|
||
| target 'Magnet' do |
There was a problem hiding this comment.
Uh! Now we need both cocoapods and carthage?
| } | ||
|
|
||
| class MagnetMetadataClient: NSObject { | ||
| let metadataServerUrl: NSURL = NSURL(string: "https://tengam.org/api/v1/metadata")!; |
|
In order to compile this, I had to manually add the folder SwiftSerializer from Pods into the dependencies. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.