Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strip console.log and propTypes from production build #316

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Strip console.log and propTypes from production build #316

wants to merge 1 commit into from

Conversation

gmarty
Copy link
Contributor

@gmarty gmarty commented Nov 7, 2016 •
edited by oteo
Loading

This PR applies 2 low-hanging fruits related to production build:

  • Strip calls to console.* as per console.log statements.
  • Strip propTypes from classes. This plugin is widely used in React but I couldn't find any clue on how useful it would be in React Native. My guess is it will remove some code and may possibly have a good impact on JS parsing time. PropTypes are not used in production anyway.

@wilsonpage
Copy link
Collaborator

LGTM @gmarty r+

@gmarty gmarty self-assigned this Nov 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@gmarty gmarty

Labels
in progress
Projects
None yet
Milestone
Gate 0 - Sprint 9 [until Dec 2nd]
Development

Successfully merging this pull request may close these issues.
3 participants
@gmarty @wilsonpage @oteo