Skip to content

Conversation

@lmarceau
Copy link
Contributor

@lmarceau lmarceau commented Oct 3, 2025

📜 Tickets

Jira ticket
Github issue

💡 Description

  • Add a new swiftUIText check to make sure we don't use Text("") for Localized Strings. If someone uses Text(verbatim: "" there should be no trigger
  • We'll fail the PR if there is such usage detected in the code
  • I created a new CodeUsageDetector class just to bundle the code together a bit so it's easier to know what relates to what in that file.

📝 Checklist

  • I filled in the ticket numbers and a description of my work
  • I updated the PR name to follow our PR naming guidelines
  • I ensured unit tests pass and wrote tests for new code
  • If working on UI, I checked and implemented accessibility (Dynamic Text and VoiceOver)
  • If adding telemetry, I read the data stewardship requirements and will request a data review
  • If adding or modifying strings, I read the guidelines and will request a string review from l10n
  • If needed, I updated documentation and added comments to complex code

@lmarceau lmarceau requested a review from thatswinnie October 3, 2025 14:51
@lmarceau lmarceau requested a review from a team as a code owner October 3, 2025 14:51
@mobiletest-ci-bot
Copy link

mobiletest-ci-bot commented Oct 3, 2025

🧹 Tidy commit

Just 1 file(s) touched. Thanks for keeping it clean and review-friendly!

🙌 Friday high-five

Thanks for pushing us across the finish line this week! 🙌

💬 Description craftsman

Great PR description! Reviewers salute you 🫡

Generated by 🚫 Danger Swift against a005c47

@lmarceau lmarceau force-pushed the lm/danger-text-detection branch from 69264d9 to a005c47 Compare October 3, 2025 17:47
@lmarceau
Copy link
Contributor Author

lmarceau commented Oct 3, 2025

Danger worked too well 😆 I don't want it to fail on the Dangerfile for code usage detection haha, so I fixed that

Screenshot 2025-10-03 at 1 48 17 PM

Copy link
Collaborator

@thatswinnie thatswinnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@lmarceau lmarceau merged commit 4da2912 into main Oct 6, 2025
8 checks passed
@lmarceau lmarceau deleted the lm/danger-text-detection branch October 6, 2025 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants